From 76a7b2747da96ddf236d0d5341e6d157059903f4 Mon Sep 17 00:00:00 2001
From: Matthieu Maitre <mmaitre@microsoft.com>
Date: Wed, 12 Oct 2022 15:47:20 -0700
Subject: [PATCH] Address PR feedback

---
 setup/setup-ci/security-scanner/README.md               | 2 +-
 setup/setup-ci/security-scanner/tests/amlsecscan.json   | 2 +-
 setup/setup-ci/security-scanner/tests/deploy.json       | 4 ++--
 setup/setup-ci/security-scanner/tests/test_trivy_3.json | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/setup/setup-ci/security-scanner/README.md b/setup/setup-ci/security-scanner/README.md
index 83f8dc29ed7..854e10ddaf6 100644
--- a/setup/setup-ci/security-scanner/README.md
+++ b/setup/setup-ci/security-scanner/README.md
@@ -12,7 +12,7 @@ description: Sample setup script to scan Compute Instances for malware and secur
 
 [![license: MIT](https://img.shields.io/badge/License-MIT-purple.svg)](../../../LICENSE)
 
-A security scanner for Azure ML [Compute Instances](https://learn.microsoft.com/en-us/azure/machine-learning/concept-compute-instance) reporting malware and vulnerabilities in OS and Python packages to [Azure Log Analytics](https://learn.microsoft.com/en-us/azure/azure-monitor/logs/log-analytics-overview).
+A security scanner for Azure ML [Compute Instances](https://learn.microsoft.com/en-us/azure/machine-learning/concept-compute-instance) reporting malware and vulnerabilities in OS and Python packages to [Azure Log Analytics](https://learn.microsoft.com/en-us/azure/azure-monitor/logs/log-analytics-overview). For details on the vulnerability management process for the Azure Machine Learning service, see [Vulnerability Management](https://learn.microsoft.com/azure/machine-learning/concept-vulnerability-management).
 
 ## Getting Started
 
diff --git a/setup/setup-ci/security-scanner/tests/amlsecscan.json b/setup/setup-ci/security-scanner/tests/amlsecscan.json
index 56eb8a1130c..1c46703cddf 100644
--- a/setup/setup-ci/security-scanner/tests/amlsecscan.json
+++ b/setup/setup-ci/security-scanner/tests/amlsecscan.json
@@ -1,3 +1,3 @@
 {
-    "logAnalyticsResourceId": "/subscriptions/23782349-c970-4549-acbb-7ed9d00ebb32/resourceGroups/DefaultResourceGroup-WUS2/providers/Microsoft.OperationalInsights/workspaces/AmlDev"
+    "logAnalyticsResourceId": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.OperationalInsights/workspaces/{workspace_name}"
 }
diff --git a/setup/setup-ci/security-scanner/tests/deploy.json b/setup/setup-ci/security-scanner/tests/deploy.json
index 28eca677e91..cf2b417c306 100644
--- a/setup/setup-ci/security-scanner/tests/deploy.json
+++ b/setup/setup-ci/security-scanner/tests/deploy.json
@@ -4,7 +4,7 @@
   "resources": [
     {
       "type": "Microsoft.MachineLearningServices/workspaces/computes",
-      "name": "AmlDev/test-amlsecscan",
+      "name": "{azure_ml_workspace_name}/{azure_ml_compute_name}",
       "location": "westus2",
       "apiVersion": "2021-07-01",
       "properties": {
@@ -19,7 +19,7 @@
             "scripts": {
               "creationScript": {
                 "scriptSource":"inline",
-                "scriptData":"[base64('sudo python3 mmaitre/amlsecscan.py install')]",
+                "scriptData":"[base64('sudo python3 {user_name}/amlsecscan.py install')]",
                 "timeout": "10m"
               }
             }
diff --git a/setup/setup-ci/security-scanner/tests/test_trivy_3.json b/setup/setup-ci/security-scanner/tests/test_trivy_3.json
index df524843d61..6d317e6a637 100644
--- a/setup/setup-ci/security-scanner/tests/test_trivy_3.json
+++ b/setup/setup-ci/security-scanner/tests/test_trivy_3.json
@@ -1,6 +1,6 @@
 {
   "SchemaVersion": 2,
-  "ArtifactName": "mmaitre-mdc4",
+  "ArtifactName": "test-mdc4",
   "ArtifactType": "filesystem",
   "Metadata": {
     "OS": {
@@ -20,7 +20,7 @@
   },
   "Results": [
     {
-      "Target": "mmaitre-mdc4 (ubuntu 18.04)",
+      "Target": "test-mdc4 (ubuntu 18.04)",
       "Class": "os-pkgs",
       "Type": "ubuntu",
       "Vulnerabilities": [