Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular imports #381

Closed
martines3000 opened this issue Mar 24, 2024 · 4 comments · Fixed by #382
Closed

Circular imports #381

martines3000 opened this issue Mar 24, 2024 · 4 comments · Fixed by #382
Assignees
Labels

Comments

@martines3000
Copy link

Hi. I found that 2 files have circular imports.

N3DataFactory.js and N3Utils.js

import { isDefaultGraph } from './N3Util';

import N3DataFactory from './N3DataFactory';

@RubenVerborgh
Copy link
Member

Is there a situation where this leads to problems? This is compiled away.

@martines3000
Copy link
Author

Its compiled away in the browser version (n3.min.js), but the cyclic import is still there in the lib folder on NPM.

Its causing some errors and I also get a warning from rollup about circular dependencies.

@RubenVerborgh
Copy link
Member

Ok, let me look into it!

@RubenVerborgh RubenVerborgh self-assigned this Mar 24, 2024
@martines3000
Copy link
Author

Thank you, much appreciated. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants