Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chemical component names to groupList entries? #1

Open
arose opened this issue Apr 18, 2016 · 5 comments
Open

Add chemical component names to groupList entries? #1

arose opened this issue Apr 18, 2016 · 5 comments

Comments

@arose
Copy link
Contributor

arose commented Apr 18, 2016

specifically _chem_comp.name from the mmcif dictionary

@pwrose
Copy link
Collaborator

pwrose commented May 17, 2016

I think these names are important since 3D viewer applications, etc. need to be able to display those names, esp. for ligands.

@abradle
Copy link
Collaborator

abradle commented May 26, 2016

After discussion the consensus was:

  1. Naming data can be found from the entity information
  2. Addition of this data would be a bit to feature creepy

So let's not add it in and I'm gonna close this for the time being.

@abradle abradle closed this as completed May 26, 2016
@arose
Copy link
Contributor Author

arose commented May 26, 2016

I think we should add it as we have a names for entities, chains, atoms. Come to think of it, model names would be good too (and might be part of an upcoming cif extension in some form I guess). I don't see adding the group name as feature creep as it is consistent with the data we provide on other levels.

I agree that for standard amino acids the three letter code is probably okay but what about modified residues?

Note that non-polymeric molecules/ligands are not relevant here as they are described in the entityList.

@BobHanson
Copy link

OK, chiming in -- Sounds like there is good support for having those names. I appreciate that, as Jmol does a lot with those -- displays them upon file load and adds them to the popup menu, for example. The most important for me are the nonstandard aa.

Yes, some are in the entityList, but that is only for ones that are individual. Other entities, for example small polysaccharides, are only listed in entityList as "SUGAR (3-MER)" for example. 1cdr. And it is quite a chore to match up the entity name with the group itself.

@arose
Copy link
Contributor Author

arose commented Aug 15, 2016

reopening for further discussion as it has come up multiple times

@arose arose reopened this Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants