Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cubic hermite interpolation for all playback (including overdubbing) #5

Closed
rconstanzo opened this issue May 9, 2015 · 4 comments

Comments

@rconstanzo
Copy link
Owner

Currently using linear interpolation for playback while overdubbing to avoid "1 sample behind the playhead" bleed, causing an aliasing sound while recording. Switch to the cubic hermite interpolation for all playback by avoiding the play and record heads being near each other.

@steadykammer
Copy link
Collaborator

this is mainly done in version 1.5, but need to test overdubbing.
higher order interpolations for record (ipoke style etc) will not happen until version 2.0

@rconstanzo
Copy link
Owner Author

Commit 3c6098d implements this and appears to be working. But there is still a bit of an issue when going to/from overdub at slower speeds. This may be "working as intended" though, given that record doesn't have fancy pants interpolation.

Steps to reproduce:
Create a loop and set speed to something low (0.1), then fill the buffer with vibes-a1.aif. Set overdub param to 0.0. Then send record messages to go into and out of overdub mode.

Actual results:
When playback is normal, interpolation sounds smooth. The moment you go into overdub mode, the playback of the vibes sounds interpolate-y.

Expected results:
It should sound the same.

*it may be worth closing this issue and raising a separate one that deals with overdub specifically, to declutter things.

@steadykammer
Copy link
Collaborator

steadykammer commented Dec 8, 2017 via email

@rconstanzo
Copy link
Owner Author

Closing this one since issue #39 will take over from here.

Fixed in commit 3c6098d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants