Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching from box on bottom of Interactive Search #90

Open
sbrl opened this issue Sep 30, 2020 · 3 comments
Open

Allow searching from box on bottom of Interactive Search #90

sbrl opened this issue Sep 30, 2020 · 3 comments
Labels
enhancement Feature requests or improvements

Comments

@sbrl
Copy link

sbrl commented Sep 30, 2020

If I execute the following:

bh -i
<then enter some  text>

....then I can enter the interactive search. If I press Tab though, my cursor jumps to bottom of the screen and I can type something in. However it doesn't seem to have any effect.

What does this do? I was hoping I could type a new query into the box without having to restart bh -i.

@rcaloras
Copy link
Owner

rcaloras commented Oct 1, 2020

@sbrl thanks for the feedback! I actually haven't really noticed this before. Good call out.

The box at the bottom I believe is an extension of the view used for displaying results. It came essentially 'out of the box' with the library used for Bashhub's interactive search, npyscreen. Having this section handle another query would be pretty cool and should be straight forward to implement.

Any interest in trying a PR? The change would be almost entirely in i_search.py I believe.

@sbrl
Copy link
Author

sbrl commented Oct 1, 2020

Ah, I see. Thanks for the explanation!

I'm actually pretty busy at the moment (and my Python is quite rusty :P), so unfortunately I don't have time to submit a PR :-/

@rcaloras rcaloras added the enhancement Feature requests or improvements label Oct 1, 2020
@rcaloras rcaloras changed the title What is the box that I can type in if I press tab? Allow searching from box on bottom of Interactive Search Oct 1, 2020
@rcaloras
Copy link
Owner

rcaloras commented Oct 1, 2020

No doubt. Updating the description here and will leave open as this is an opportunity for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

No branches or pull requests

2 participants