-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback wanted! #240
Comments
What happens if I try to use v2 using Ruby 2.5? Debian Stable (v10, Buster) comes with 2.5 and I'd rather not have to install a newer version from source. |
It'll break; we started using some new features from 2.6. 2.5 is pretty old, and actually officially went EOL yesterday. You don't have to build from source yourself; handling different versions of programming languagese is such a common problem that there are several good tools out there to handle it. asdf is the one I use, and can recommend it. rbenv is a ruby-specific alternative. |
Yes but then it effectively bypasses Debian package management system. As a rule, I try to avoid doing that. It only causes problems in future. I'll try to find a Debian friendly way of updating to 2.6. |
I would love to know if anyone's successfully used JPT in Cloudflare Pages! |
I just tried a test build, looks like it's similar to netlify. No
|
I am having a problem using JPT with Jekyll-Polyglot. It re-generates all of the images for every build. JPT seems to be not aware of the generated hash. Any clue? |
I am having an issue with deploying to Netlify. Do i need something more in my build command than simply
I guess it is because it doesn't find vips-tools? I have tried the build command My build works if i dont use JPT. Am I missing something? Thank you for your plugin! |
@sbij Are you running their 2.0.2 build or later? I believe that's when they added vips. |
@rbuchberger yes |
I mean the netilfy build - site settings -> deploy -> build image. They've changed it since I last looked though; I believe you want the Ubuntu 20.04 image? Unless they pulled libvips out of it. |
I am using Ubuntu Focal 20.04 indeed, other option is Ubuntu Xenial 16.04. I don't mind using either i think. Sorry i'm not sure where to find the 2.0.2 info (edit: i get this info in my build log: |
Are you still having issues @sbij? The jpt tester repo builds successfully for me on Netlify with Ubuntu 20.04 and |
@duffn i retried on Netlify (i switched to Cloudflare pages at the time, because of this issue) and now i dont have anymore problems, it works well with my repo on github |
Hi @rbuchberger, rather than generating the images locally, could you rely on the https://docs.netlify.com/image-cdn/overview/ ? that's what I've been doing, but I think there may be a workable way to do what you're doing with some SaaS model |
Hi @andreadellacorte, thanks for the idea! I'm sorry to say that I flat out don't have the time or energy to build a feature like that. I'll happily accept pull requests, however. |
I think I built it tonight!! Tested it on my website and it works. It's wonky because I'm not the best at liquid filters parameters (it's a bit of a nightmare, I've found), but I think you'd be able to integrate it easily in your more mature set up. I can make a gist and show you where I'm at, then we can discuss integrating and prs if you think it worthwhile. |
Sounds great! I'd love to see it. |
Emailed. |
With the 2.0 release, it's time for a new feedback thread. I moved the old one to a discussion thread awhile ago, but apparently nobody uses github discussions because it's been pretty dead. I want to hear about any of the following:
Thanks!
The text was updated successfully, but these errors were encountered: