Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests : Maria DB missing. #599

Open
rathnadhar opened this issue Sep 14, 2024 · 5 comments
Open

Tests : Maria DB missing. #599

rathnadhar opened this issue Sep 14, 2024 · 5 comments

Comments

@rathnadhar
Copy link

Namaskara,

Thanks for this wonderful library.

I am coding a OSS based trader. I wanted to use SQLPP11.

I cloned the git repository and built it. However I am not seeing any file (or section related to Mariadb). I see sections on Mysql, PostGresql and SQL lite. Mariadb seems missing. Can I go head and use mySql for MariaDB backend?

I will be wonderful if you can add tests for Mariadb.

With Warm Regards,
Rathnadhar K V

@rbock
Copy link
Owner

rbock commented Sep 14, 2024

Hi Rathnadhar,

Thanks for the nice feedback!

Admittedly, it has been a while since last I tested with MariaDB (and right now, I cannot test it myself), but you should be able to use instead of MySQL. Please give it a try and let me know whether it worked?

That said, true, I should add tests for MariaDB.

Best,
Roland

@MeanSquaredError
Copy link
Contributor

MeanSquaredError commented Sep 14, 2024

@rathnadhar

sqlpp11 works fine with MariaDB, just use the MySQL connector and connect to the MariaDB database. Also all sqlp11 MySQL tests pass correctly with a MariaDB backend.

MariaDB and MySQL are pretty much the same database.

EDIT: All of the PRs that I submit are tested with PostgreSQL, MySQL (I actually use a MariaDB database) and SQLite3. The last PR that I submitted was 2-3 weeks ago, so I am pretty sure that the MySQL/MariaDB connector works fine.

@MeanSquaredError
Copy link
Contributor

Essentially when the CMake option BUILD_MARIADB_CONNECTOR is enabled it checks if MariaDB is installed, but the user should use the MySQL connector, because MariaDB is (mostly) the same database as MySQL, so there is no point in duplicating the code.

The situation with SQLite3 and SQLCipher connectors is similar. We only have code for the SQLite3 connector and if the user wants to connect to an SQLCipher database, then he should use the SQLite3 connector.

I think that this is mostly a documentation issue and it could be resolved by updating the documentation.

@rbock
Copy link
Owner

rbock commented Sep 14, 2024

Thanks for the confirmation, @MeanSquaredError !

Yes, it is primarily a documentation issue. It might still make sense to add a tests that make use of an actual MariaDB backend (same with SQLCipher).

@rathnadhar
Copy link
Author

rathnadhar commented Sep 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants