Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keepassxc extension #17758

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

pabroux
Copy link
Contributor

@pabroux pabroux commented Mar 11, 2025

Description

Hello 👋🏻,

⚠️ Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech).

Here is what I've done:

Changed

  • Use a global info message about security when the database is locked.
  • Update screenshot about the database being locked.
  • Use more explicite error messages when unable to exececute the keepassxc-cli command.

Fixed

  • Use a correct link for the KeePassXC image in the README.

Removed

  • The test guide.

Checklist

- chore(CHANGELOG): add logs for 1.5.5.
- fix: handle the invalid credentials error message.
- chore(npm): update packages.
- chore: remove test guide.
- docs(assets): update screenshot for unlocking database.
- feat(unlock): improve UI for info.
- chore: add .vscode to .gitignore.
- docs(README): fix link for image.
- chore: delete \'.vscode\'.
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: keepassxc Issues related to the keepassxc extension labels Mar 11, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Mar 11, 2025

Thank you for your contribution! 🎉

🔔 @zkytech you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the KeePassXC extension with improved error messaging, documentation changes, and dependency updates.

  • There's a spelling error in CHANGELOG.md: "explicite" should be "explicit" in the error message description
  • The error message in keepass-loader.ts removes specific error codes which could make debugging harder, consider keeping detailed errors in logs
  • The security message in unlock-database.tsx is now consolidated but could be more prominent given its importance
  • Dependencies @raycast/api and @raycast/utils have been updated to newer minor versions
  • The README image source now correctly uses repository-relative paths instead of external URLs

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

pabroux and others added 2 commits March 11, 2025 16:04
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@LitoMore
Copy link
Contributor

Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech)

It's because the mapping data in the raycast2github.json is wrong. We might need to fix it manually:

"pabroux": "zkytech",

@pabroux
Copy link
Contributor Author

pabroux commented Mar 11, 2025

Still the author here and not the contributor (raycastbot still incorrectly notifies the former author zkytech)

It's because the mapping data in the raycast2github.json is wrong. We might need to fix it manually:

"pabroux": "zkytech",

I've done a commit to change the mapping 4b6df1b.

Edit: 381a6db to merge conflicts.

@pabroux pabroux requested a review from LitoMore March 11, 2025 18:24
@pabroux pabroux requested a review from LitoMore March 12, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: keepassxc Issues related to the keepassxc extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants