Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connect-to-vpn extension #16004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yshmeel
Copy link

@Yshmeel Yshmeel commented Dec 22, 2024

Description

Fixes behavior when extension spawning zombie processes while updating services statuses in background

Resolves #15990

Screencast

Checklist

- fix spawning zombie process while updating services status in background
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: connect-to-vpn Issues related to the connect-to-vpn extension labels Dec 22, 2024
@raycastbot
Copy link
Collaborator

Thank you for your first contribution! 🎉

🔔 @rasmusbe @sato11 @stonerl @vpukhanov you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄

@LayXL
Copy link

LayXL commented Dec 22, 2024

LGTM, solves the zombie process problem

@stonerl
Copy link
Contributor

stonerl commented Dec 22, 2024

LGTM

Copy link
Contributor

@rasmusbe rasmusbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: connect-to-vpn Issues related to the connect-to-vpn extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Connect to VPN] Create defunct processes every 30 seconds
5 participants