Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; release tests] Fix config.rollouts -> config.env_runners deprecation errors. #49418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 24, 2024

Fix config.rollouts -> config.env_runners deprecation errors.

  • Replace deprecated calls to AlgorithmConfig.rollouts with AlgorithmConfig.env_runners.
  • Replace deprecated AlgorithmConfig.num_env_per_worker with AlgorithmConfig.num_envs_per_env_runner.

Why are these changes needed?

Related issue number

Closes #49397
Closes #49396

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test long_running_impala.aws failed Release test ml_user_tune_rllib_connect_test.aws failed
1 participant