Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib; release tests] Fix config.rollouts -> config.env_runners deprecation errors. #49418

Merged
merged 2 commits into from
Dec 27, 2024
Merged

[RLlib; release tests] Fix config.rollouts -> config.env_runners deprecation errors. #49418

merged 2 commits into from
Dec 27, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 24, 2024 •
edited
Loading

Fix config.rollouts -> config.env_runners deprecation errors.

  • Replace deprecated calls to AlgorithmConfig.rollouts with AlgorithmConfig.env_runners.
  • Replace deprecated AlgorithmConfig.num_env_per_worker with AlgorithmConfig.num_envs_per_env_runner.

Why are these changes needed?

Related issue number

Closes #49397
Closes #49396

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 enabled auto-merge (squash) December 27, 2024 13:18
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 27, 2024
@sven1977 sven1977 added rllib RLlib related issues release-test release test rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Dec 27, 2024
simonsays1980
simonsays1980 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 27, 2024
@sven1977 sven1977 merged commit 4da40d6 into ray-project:master Dec 27, 2024
7 checks passed
@sven1977 sven1977 deleted the fix_release_tests_rollouts_vs_env_runners branch December 27, 2024 20:08
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
@sven1977 @srinathk10
[RLlib; release tests] Fix config.rollouts -> config.env_runners …
c024a0c 
…deprecation errors. (#49418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests release-test release test rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release test long_running_impala.aws failed Release test ml_user_tune_rllib_connect_test.aws failed
2 participants
@sven1977 @simonsays1980