Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Enum' name defined / assigned to in enums.js polutes the global namespace #8

Open
octavian-nita opened this issue Jun 18, 2015 · 0 comments

Comments

@octavian-nita
Copy link

Hi guys,

Currently, the 'Enum' name gets defined in the enums module as follows:

Enum = function (obj) {

Since var is not used in the definition, this 'polutes' the JavaScript global namespace with the Enum name. I assume this wasn't the original intent, rather something like:

var Enum = function (obj) {

Or... even simpler:

function Enum(obj) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant