Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model parsing discussion #32

Open
landmanbester opened this issue Sep 1, 2021 · 1 comment
Open

Model parsing discussion #32

landmanbester opened this issue Sep 1, 2021 · 1 comment

Comments

@landmanbester
Copy link

As promised in the meeting, I am opening this to discuss all things model parsing related @o-smirnov @JSKenyon @sjperkins @bennahugo. It seems that there is a need to parse complex models, possibly consisting of a mixture of component models (for both morphology and frequency spectrum) as well as pixelated images/facets. The former should be evaluated as accurately as possible using a parametrised DFT while the latter get's processed using a degridder. This functionality already exists (to some extent) in CubiCal but the model specification has become rather convoluted. The dream is to have a single parser that can concatenate different combinations of models and keep track of how each one should be predicted. I think the consensus was that tigger-lsm should be the parser with the API possibly living in codex-africanus. I see we were already thinking along these lines in 2019 ratt-ru/codex-africanus#85. But it may also be preferable to have a separate application to handle the predict. Ideas?

@sjperkins
Copy link
Member

I was thinking about this yesterday.

  • The way the model is currently specified in codex requires working it into NumPy arrays, which in turn means that sources with different characteristics must be partitioned into groups which must be predicted separately.
  • Alternatively, it may be possible to come up with some suitably generic dictionary/list model that can be represented in Numba.
  • This means that the dictionary/list will be strictly typed so it won't be quite as loose as a pure Python dictionary, but it may be loose enough that we can process multiple source types in one function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants