Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting for aberration in plane of sky coordinates #305

Open
Joshuaalbert opened this issue Apr 10, 2024 · 9 comments
Open

Accounting for aberration in plane of sky coordinates #305

Joshuaalbert opened this issue Apr 10, 2024 · 9 comments

Comments

@Joshuaalbert
Copy link

I couldn't find where you accounting for aberration in the calculation of lmn coordinates. All the calculations seem to be ignorant of time. These coordinates are conjugate to the uvw coordinates, and thus also have an effect related to motion of the observer relative to the inertial reference frame of the coordinate system. For the UVW there are two inertial reference frames often used: Solar system barycentre, and Earth's barycentre. CASA use's Earth's barycentre in the UVW calculation, VLBI uses solar system's. In both cases, the orientation of the frame exactly matches ICRS coordinate frame, so that l/u points along RA and m/v points along DEC.

What this means is that if you convert RA/DEC into l and m without taking into account motion, i.e. time, you'll get wrong results.

To illustrate this here I plot the astrometry error over the plane of sky (l,m coords) induced by aberration (and what happens when you ignore time).

separation(lm_to_icrs(l, m, phase_centre, t0 + offset), lm_to_icrs(l, m, phase_centre, t0))

Screenshot from 2024-04-10 18-30-01

Notice, after exactly 1 year the difference is again minimal, because the Earth is (nearly) in the same spot. The peak error is reached around 6 months.

Here's the error v.s. sqrt(l^2 + m^2) over the course of a year's offset.

Screenshot from 2024-04-10 18-44-13

Of course, as is usual, for narrow fields of view it's negligible. But, for wide field of view it's good to take into account, and not too hard either.

@landmanbester
Copy link
Collaborator

Of course, as is usual, for narrow fields of view it's negligible. But, for wide field of view it's good to take into account, and not too hard either.

Yup we definitely need this for VLBI but quite low on the priority list for MeerKAT. Would you consider making a PR @Joshuaalbert ?

@Joshuaalbert
Copy link
Author

I can share the code once I publish the DSA code repo

@bennahugo
Copy link
Collaborator

bennahugo commented Apr 12, 2024 via email

@bennahugo
Copy link
Collaborator

bennahugo commented Apr 12, 2024

I see ICRS is barycentric not heliocentric. Sorry. Am I correct in saying that we need to go from (edit ICRS -> GCRS -> spherical cosines [for projection onto a geocentric uvw basis]). I should note that I don't think any of the imaging software actually does this, but it is something I should be doing for TART (not that it matters at the current resolution though!)

@ludwigschwardt
Copy link

ludwigschwardt commented Apr 12, 2024

The major effect of aberration on the image plane is a uniform scaling (up to 1 ± 1e-4 for annual aberration). This would be taken care of in the UVW calculations if UVW is based on delay differentials like in CALC - an upgrade I still plan for katpoint this year. The effect on MeerKAT images are tiny (shifts much less than a pixel width).

Here is a nice exaggerated representation of what your image plane does over a year (courtesy of @bmerry) to give your stomach some aberration 😂

aberration

💡 Come to think of it, maybe this explains why CALC sometimes calculates (u, v) coordinates without aberration, something I've always wondered about... Then the lmn coordinates can incorporate that, since (u, v) can only correct linear scaling and rotation around the phase centre and not non-linear warping far away from the phase centre. That would be easier to fix in lmn space 🤔

@landmanbester
Copy link
Collaborator

an upgrade I still plan for katpoint this year.

Does this upgrade also include documentation? 😉

@Joshuaalbert
Copy link
Author

Nice visual! The UV coordinates in the precise formulation are as u=d/dl phi, v=d/dm phi where phi is a delay function including motion of the observer relative to inertial reference frame, and the gravitational potential of the antennas. There was a paper somewhere I read on it once, but can't find now. But, anyways this gives rise to a nice definition for u,v. I think l,m are inversely defined as l=d/du (phi/2pi) and m=d/dv (phi/2pi), so that in the simple case when phi = 2 pi (u*l + v*m) we recover the expected results. Things like motion and gravity alter the form of phi giving more terms and denominators, etc.

So I think even if the u,v coordinates taking into account aberration, the calculation of l,m needs to as well.

@Joshuaalbert
Copy link
Author

@ludwigschwardt
Copy link

Thanks Joshua! I followed your attempts to add UVW to Astropy (astropy/astropy#6882, astropy/astropy#9869, astropy/astropy#10737) with great interest in the past. I also maintain yet another CALC wrapper. I'd love to continue this conversation once I hit the katpoint UVW code again 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants