From d46f09c61977a3f0896282ef340956f8ef9fa558 Mon Sep 17 00:00:00 2001
From: popcornmix <popcornmix@gmail.com>
Date: Tue, 31 Mar 2020 12:20:04 +0100
Subject: [PATCH 1/3] Fix ds target for gic

---
 armstubs/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/armstubs/Makefile b/armstubs/Makefile
index e6035719..8d565adf 100644
--- a/armstubs/Makefile
+++ b/armstubs/Makefile
@@ -66,6 +66,9 @@ clean :
 %8.ds: %8.bin
 	$(OBJDUMP8) -D --target binary $< > $@
 
+%8-gic.ds: %8-gic.bin
+	$(OBJDUMP8) -D --target binary $< > $@
+
 %.ds: %.bin
 	$(OBJDUMP7) -D --target binary $< > $@
 

From 5012cb3339aa4eafcc5e029aa0257040a8b55748 Mon Sep 17 00:00:00 2001
From: popcornmix <popcornmix@gmail.com>
Date: Mon, 15 Jun 2020 14:03:28 +0100
Subject: [PATCH 2/3] armstub7: Increase GIC version to 0x200

Currently only one free instruction for GIC code below 0x100
so move it above 0x100 live armstub8
---
 armstubs/armstub7.S | 65 ++++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 30 deletions(-)

diff --git a/armstubs/armstub7.S b/armstubs/armstub7.S
index eac14cd2..d4668aa7 100644
--- a/armstubs/armstub7.S
+++ b/armstubs/armstub7.S
@@ -93,37 +93,8 @@ jmp_loader:
 	mrc p15, 0, r7, c0, c0, 5 @ Put core number into R7
 
 #ifdef GIC
-
-#define GIC_CPUB_offset 0x1000
-
-#define GICC_CTRLR	0x0
-#define GICC_PMR	0x4
-#define IT_NR		0x8		@ Number of interrupt enable registers (256 total irqs)
-#define GICD_CTRLR	0x0
-#define GICD_IGROUPR	0x80
-
-setup_gic:				@ Called from secure mode - set all interrupts to group 1 and enable.
-	ldr	r2, GIC_DISTB
-
-	ands    r7,r7, #3		@ primary core
-
-	movne	r0, #3			@ Enable group 0 and 1 IRQs from distributor
-	strne	r0, [r2,  #GICD_CTRLR]
-
-	mov     r0, #~0
-	mov	    r1, #~0			@ group 1 all the things
-	strd    r0, r1, [r2,#(GICD_IGROUPR)]!	@ update to bring the CPU registers within range
-	strd    r0, r1, [r2,#8]
-	strd    r0, r1, [r2,#16]
-
-	movw	r1, #0x1e7
-	str	r1, [r2, #(GIC_CPUB_offset - GICD_IGROUPR) ]! @ Enable group  1 IRQs from CPU interface
-
-	movw	r1, #0xff
-	str	r1, [r2, #GICC_PMR] @ priority mask
-
+	bl      setup_gic
 #endif
-
 	mov r0, #1
 	mcr p15, 0, r0, c14, c3, 1 @ CNTV_CTL (enable=1, imask=0)
 
@@ -171,3 +142,37 @@ setup_gic:				@ Called from secure mode - set all interrupts to group 1 and enab
 .word 0			@ version
 atags:	.word 0x0	@ device tree address
 kernel:	.word 0x0	@ kernel start address
+
+.org 0x100
+
+#ifdef GIC
+
+#define GIC_CPUB_offset 0x1000
+
+#define GICC_CTRLR	0x0
+#define GICC_PMR	0x4
+#define IT_NR		0x8		@ Number of interrupt enable registers (256 total irqs)
+#define GICD_CTRLR	0x0
+#define GICD_IGROUPR	0x80
+
+setup_gic:				@ Called from secure mode - set all interrupts to group 1 and enable.
+	ldr	r2, GIC_DISTB
+
+	ands    r7,r7, #3		@ primary core
+
+	movne	r0, #3			@ Enable group 0 and 1 IRQs from distributor
+	strne	r0, [r2,  #GICD_CTRLR]
+
+	mov     r0, #~0
+	mov	    r1, #~0			@ group 1 all the things
+	strd    r0, r1, [r2,#(GICD_IGROUPR)]!	@ update to bring the CPU registers within range
+	strd    r0, r1, [r2,#8]
+	strd    r0, r1, [r2,#16]
+
+	movw	r1, #0x1e7
+	str	r1, [r2, #(GIC_CPUB_offset - GICD_IGROUPR) ]! @ Enable group  1 IRQs from CPU interface
+
+	movw	r1, #0xff
+	str	r1, [r2, #GICC_PMR] @ priority mask
+	bx	lr
+#endif

From 6cb534dadfb7c05a8049b788b36d3328e945c0c5 Mon Sep 17 00:00:00 2001
From: popcornmix <popcornmix@gmail.com>
Date: Mon, 15 Jun 2020 14:03:46 +0100
Subject: [PATCH 3/3] armstub7: Also reset CNTVOFF

---
 armstubs/armstub7.S | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/armstubs/armstub7.S b/armstubs/armstub7.S
index d4668aa7..5bd38034 100644
--- a/armstubs/armstub7.S
+++ b/armstubs/armstub7.S
@@ -58,6 +58,9 @@ _secure_monitor:
 	mcr	p15, 1, r1, c9, c0, 2		@ Write L2CTLR
 #endif
 
+	@ Reset CNTVOFF to 0 before leaving monitor mode
+	mov     r0, #0
+	mcrr    p15, 4, r0, r0, c14		@ Reset CNTVOFF to zero
 	movs	pc, lr				@ return to non-secure SVC
 
 value:		.word 0x63fff