Skip to content

Commit

Permalink
drm/vc4: Drop WARN for HVS FIFOs not being empty
Browse files Browse the repository at this point in the history
The reset condition for the EMPTY flag in DISPSTATx is 0,
so seeing as we've just reset the pipeline there is no
guarantee that the flag will denote empty if it hasn't been
enabled.

Drop the WARN.

Signed-off-by: Dave Stevenson <[email protected]>
  • Loading branch information
6by9 committed Oct 26, 2023
1 parent 77f030b commit 2d65ae4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/gpu/drm/vc4/vc4_hvs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1005,10 +1005,6 @@ static void __vc4_hvs_stop_channel(struct vc4_hvs *hvs, unsigned int chan)
SCALER_DISPSTATX_MODE) !=
SCALER_DISPSTATX_MODE_DISABLED);

WARN_ON_ONCE((HVS_READ(SCALER_DISPSTATX(chan)) &
(SCALER_DISPSTATX_FULL | SCALER_DISPSTATX_EMPTY)) !=
SCALER_DISPSTATX_EMPTY);

out:
drm_dev_exit(idx);
}
Expand Down

0 comments on commit 2d65ae4

Please sign in to comment.