Merge pull request #173 from rasg-affiliates/fix_ska_profile

Fix hard-coded dish size in from_ska method
rasg-affiliates · Feb 24, 2025 · 15952dd · 15952dd
2 parents c79681f + 8aee63a
commit 15952dd
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/src/py21cmsense/data/profiles/HERA-H1C-IDR3.yaml b/src/py21cmsense/data/profiles/HERA-H1C-IDR3.yaml
@@ -1,5 +1,5 @@
 antpos: !astropy.units.Quantity
-  value: !txt "{{ DATA_PATH }}/antpos/hera-h1c-idr3.txt"
+  value: !txt '{{ DATA_PATH }}/antpos/hera-h1c-idr3.txt'
   unit: !astropy.units.Unit {unit: m}
 beam:
   class: GaussianBeam

diff --git a/src/py21cmsense/data/profiles/MWA-PhaseII.yaml b/src/py21cmsense/data/profiles/MWA-PhaseII.yaml
@@ -1,5 +1,5 @@
 antpos: !astropy.units.Quantity
-  value: !txt "{{ DATA_PATH }}/antpos/mwa_phase2_compact_antpos.txt"
+  value: !txt '{{ DATA_PATH }}/antpos/mwa_phase2_compact_antpos.txt'
   unit: !astropy.units.Unit {unit: m}
 beam:
   class: GaussianBeam

diff --git a/src/py21cmsense/data/profiles/SKA-LOW1-central.yaml b/src/py21cmsense/data/profiles/SKA-LOW1-central.yaml
@@ -1,5 +1,5 @@
 antpos: !astropy.units.Quantity
-  value: !txt "{{ DATA_PATH }}/antpos/layout_enu_ska_central.txt"
+  value: !txt '{{ DATA_PATH }}/antpos/layout_enu_ska_central.txt'
   unit: !astropy.units.Unit {unit: m}
 beam:
   class: GaussianBeam

diff --git a/src/py21cmsense/data/profiles/SKA-LOW1-core.yaml b/src/py21cmsense/data/profiles/SKA-LOW1-core.yaml
@@ -1,5 +1,5 @@
 antpos: !astropy.units.Quantity
-  value: !txt "{{ DATA_PATH }}/antpos/layout_enu_ska_core.txt"
+  value: !txt '{{ DATA_PATH }}/antpos/layout_enu_ska_core.txt'
   unit: !astropy.units.Unit {unit: m}
 beam:
   class: GaussianBeam

diff --git a/src/py21cmsense/observatory.py b/src/py21cmsense/observatory.py
@@ -272,7 +272,9 @@ def from_ska(
         else:
             raise ValueError("array_type must be 'low' or 'mid'.")
         antpos = subarray.array_config.xyz.data * un.m
-        _beam = beam.GaussianBeam(frequency=frequency, dish_size=35.0 * un.m)
+        _beam = beam.GaussianBeam(
+            frequency=frequency, dish_size=np.array(subarray.array_config.diameter)[0] * un.m
+        )
         lat = subarray.array_config.location.lat.rad * un.rad
         return cls(antpos=antpos, beam=_beam, latitude=lat, Trcv=Trcv)
 

diff --git a/src/py21cmsense/sensitivity.py b/src/py21cmsense/sensitivity.py
@@ -388,7 +388,7 @@ def calculate_sensitivity_2d(
             if sample:
                 total_std = sample_std = 1 / np.sqrt(
                     self._nsamples_2d["sample"][k_perp][mask]
-                    * (self.observation.time_per_day / self.observation.beam_crossing_time).to("")
+                    * (self.observation.time_per_day / self.observation.lst_bin_size).to("")
                 )
             if thermal and sample:
                 total_std = thermal_std + sample_std