Full pyproject conversion #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing I could fit in was the long description. But the readme can take its place if that's acceptable. |
|
Thanks a lot, this is awesome! (And no worries, I will try to debug the CI issues) |
|
I'll close out #1064 if you like this one better. |
|
Could you try to update the branch by pulling or rebasing from master? The CI should be fixed now. |
jmahlik
force-pushed
the
full-pyproject
branch
from
22be47e
to
ecf4a87
Compare
|
Rebased it |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 200 200
Lines 11297 11297
Branches 1513 1513
=======================================
Hits 8729 8729
Misses 2350 2350
Partials 218 218 ☔ View full report in Codecov by Sentry. |
rasbt
approved these changes
Sep 22, 2023
|
It seems to work now. Thanks a lot for this great PR and restructuring. I will make a PyPI release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code of Conduct
Description
Continuing on the conversation from #1062. Converted all the way to a pyproject. This is really slick. Everything builds and installs as expected. The
__version__thing is no longer a problem. If it's changed in the__init__.py, it is picked up automatically.Was able to delete the
setup.pyandsetup.cfgentirely by moving the pytest config and the setuptools wheel config. The "universal" wheel section in thesetup.cfgwas causing it to make python 2 compatible wheels (withpy2-py3-non-any.whl). Now it just makes apy3wheel.Let me know thoughts. Happy to make any changes. The PR is coming from a github org so you might not be able to edit it directly.
Alternative to #1064
Build output:
Related issues or pull requests
Fixes #1062
Pull Request Checklist
./docs/sources/CHANGELOG.mdfile (if applicable)./mlxtend/*/testsdirectories (if applicable)mlxtend/docs/sources/(if applicable)PYTHONPATH='.' pytest ./mlxtend -svand make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)flake8 ./mlxtend