Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] WholeMemoryTensor Gather References Nonexistent Property #168

Open
alexbarghi-nv opened this issue May 20, 2024 · 0 comments
Open

[BUG] WholeMemoryTensor Gather References Nonexistent Property #168

alexbarghi-nv opened this issue May 20, 2024 · 0 comments

Comments

@alexbarghi-nv
Copy link
Member

I believe this should be self.dtype but it is self.embedding_tensor.dtype. This causes an exception to be raised whenever the dtype is not provided.

wholegraph/python/pylibwholegraph/pylibwholegraph/torch/tensor.py

Line 70 in afb6a11

force_dtype if force_dtype is not None else self.embedding_tensor.dtype

@linhu-nv linhu-nv mentioned this issue May 27, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue May 28, 2024
@linhu-nv
a quick fix to wholememory tensor gather default data type (#173)
da0a412 
A quick fixes to this issue (#168). Set correct default wholememory tensor gather results data type.

Authors:
  - https://github.com/linhu-nv

Approvers:
  - Chuang Zhu (https://github.com/chuangz0)

URL: #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexbarghi-nv