-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Make the rmm._cuda.stream.Stream
a part of the public API
#1770
Labels
feature request
New feature or request
Comments
Matt711
changed the title
[FEA] Make the
[FEA] Make the Dec 18, 2024
rmm._cuda.stream.Stream
apart of the public APIrmm._cuda.stream.Stream
a part of the public API
cuda-python is proposing a cdef class Stream:
def __init__(self, obj=None):
self._init_from_stream(obj)
@singledispatchmethod
def _init_from_stream(self, stream):
try:
protocol = getattr(obj, "__cuda_stream__")
except AttributeError:
raise ValueError(
"stream must be a supported stream type or implement the __cuda_stream__ protocol"
)
if protocol[0] != 0:
raise ValueError("Only protocol version 0 is supported")
self._cuda_stream = stream
self.owner = stream
@_from_stream.register()
def _from_stream(self, Stream):
self._cuda_stream, self._owner = stream._cuda_stream, stream._owner
@_from_stream.register()
def _from_stream(self, stream: numba.cuda.cudadrv.driver.Stream):
# Whatever special handling for numba if needed, but ideally could just use the protocol |
3 tasks
This was referenced Jan 2, 2025
rapids-bot bot
pushed a commit
that referenced
this issue
Jan 16, 2025
Closes #1770. Authors: - Matthew Murray (https://github.com/Matt711) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I wish I could use RMM to do [...]
We're starting to expose streams to pylibcudf APIs. xref rapidsai/cudf#15163 and rapidsai/cudf#17620). Can we make
Stream
part of the public API.Describe the solution you'd like
Migrate
rmm._cuda.stream.Stream
tormm.pylibrmm.stream.Stream
. We would deprecatermm._cuda.stream.Stream
for 25.02 and remove it in 25.04.The text was updated successfully, but these errors were encountered: