Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df.join should accept singleton arguments, not just iterable. #426

Open
thomcom opened this issue Sep 1, 2022 · 0 comments
Open

df.join should accept singleton arguments, not just iterable. #426

thomcom opened this issue Sep 1, 2022 · 0 comments
Assignees

Comments

@thomcom
Copy link
Contributor

thomcom commented Sep 1, 2022

join uses forEach to join across the on: keys. A common use case of join is with a single join column, so we should accept the use of a single join argument.

keys_df.join({other: target_df, on: 'keys', how: 'inner'});

vs

keys_df.join({other: target_df, on: ['keys'], how: 'inner'});

@thomcom thomcom self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant