Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] simplicial_set_embedding does not support array as init pos #6035

Closed
Intron7 opened this issue Aug 21, 2024 · 1 comment · Fixed by #6043
Closed

[BUG] simplicial_set_embedding does not support array as init pos #6035

Intron7 opened this issue Aug 21, 2024 · 1 comment · Fixed by #6043
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@Intron7
Copy link
Contributor

Intron7 commented Aug 21, 2024

simplicial_set_embedding states in it's docstring that it support numpy arrays as the intial positions for the embedding. However that doesn't work.

Steps/Code to reproduce bug

    init: string
        How to initialize the low dimensional embedding. Options are:
            * 'spectral': use a spectral embedding of the fuzzy 1-skeleton
            * 'random': assign initial embedding positions at random.
            * A numpy array of initial embedding positions.
    if init not in ['spectral', 'random']:
        raise Exception("Initialization strategy not supported: %d" % init)

Expected behavior
Either remove the part of the docstring or better enable this.

@Intron7 Intron7 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Aug 21, 2024
rapids-bot bot pushed a commit that referenced this issue Sep 11, 2024
Answers #6041 and #6035

Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Divye Gala (https://github.com/divyegala)

URL: #6043
@divyegala
Copy link
Member

Closed by #6043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants