From 9bba4b20968cff9f86e8dd1838d9b20b36a6a9d5 Mon Sep 17 00:00:00 2001 From: Paul Mattione Date: Fri, 7 Feb 2025 10:39:40 -0500 Subject: [PATCH] disable it --- cpp/src/groupby/hash/compute_aggregations.cuh | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/cpp/src/groupby/hash/compute_aggregations.cuh b/cpp/src/groupby/hash/compute_aggregations.cuh index 9c9a4c97bff..5b4baacd8cc 100644 --- a/cpp/src/groupby/hash/compute_aggregations.cuh +++ b/cpp/src/groupby/hash/compute_aggregations.cuh @@ -1,5 +1,5 @@ /* - * Copyright (c) 2024, NVIDIA CORPORATION. + * Copyright (c) 2024-2025, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -67,13 +67,7 @@ rmm::device_uvector compute_aggregations( auto const grid_size = max_occupancy_grid_size>(num_rows); auto const available_shmem_size = get_available_shared_memory_size(grid_size); - auto const has_sufficient_shmem = - available_shmem_size > (compute_shmem_offsets_size(flattened_values.num_columns()) * 2); - auto const has_dictionary_request = std::any_of( - requests.begin(), requests.end(), [](cudf::groupby::aggregation_request const& request) { - return cudf::is_dictionary(request.values.type()); - }); - auto const is_shared_memory_compatible = !has_dictionary_request and has_sufficient_shmem; + auto const is_shared_memory_compatible = false; // Performs naive global memory aggregations when the workload is not compatible with shared // memory, such as when aggregating dictionary columns or when there is insufficient dynamic