Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ucx-proc conda dependency #142

Closed
4 tasks done
jameslamb opened this issue Jan 24, 2025 · 2 comments
Closed
4 tasks done

Remove ucx-proc conda dependency #142

jameslamb opened this issue Jan 24, 2025 · 2 comments
Assignees

Comments

@jameslamb
Copy link
Member

jameslamb commented Jan 24, 2025

Description

It should be possible for RAPIDS projects to stop depending on the ucx-proc package from conda-forge.

The package no longer has a corresponding feedstock building it... it was removed in conda-forge/ucx-split-feedstock#111. See @pentschev 's comments in rapidsai/ucxx#280 (comment)

One thing you don't need to do anymore is provide ucx-proc==cpu, conda-forge/ucx-split-feedstock#111, which is determined at runtime.*

The minimum UCX version RAPIDS supports today is 1.15.0 (code link), so it's safe to make this change.

Benefits of this work

  • faster conda solves
  • reduces risk of conflicts in environment solves

Acceptance Criteria

  • no RAPIDS projects have direct dependencies on ucx-proc packages

Approach

Search for references via https://github.com/search?q=org%3Arapidsai%20%22ucx-proc%22%20AND%20NOT%20is%3Aarchived&type=code

Update the task list below and remove those references.

Updates

Preview Give feedback
@jameslamb jameslamb self-assigned this Jan 24, 2025
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Jan 27, 2025
Contributes to rapidsai/build-planning#142

`ucx-proc` has been unnecessary for conda environments since UCX 1.14, and RAPIDS currently supports UCX 1.15+. This proposes removing that dependency from conda packages and environments here.

See the linked issue for more details.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #4894
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Jan 27, 2025
Contributes to rapidsai/build-planning#142

`ucx-proc` is no longer necessary, for the reasons described in that issue. This proposes dropping the dependency on it here.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #1429
rapids-bot bot pushed a commit to rapidsai/integration that referenced this issue Jan 28, 2025
Contributes to rapidsai/build-planning#142

Proposes removing the exclusion for `ucx-proc` in the CI job that checks that all projects have produced recent-enough nightlies. See that linked issue for much more detail, but in short:

* there haven't been new `ucx-proc` packages for 2+ years, since conda-forge/ucx-split-feedstock#111
* RAPIDS can safely drop its `ucx-proc` dependency, and other PRs linked to rapidsai/build-planning#142 have done that for the 25.02 release
* `ucx-proc` should not show up in RAPIDS 25.02 environment solves, and so we don't need to carry an exclusion for it in the testing config

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)

URL: #742
@bdice
Copy link
Contributor

bdice commented Jan 28, 2025

@jameslamb I think this might be complete. Feel free to reopen if needed.

@bdice bdice closed this as completed Jan 28, 2025
@jameslamb
Copy link
Member Author

Yep this is done, was just waiting on rapidsai/integration#742 which it looks like you just approved and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants