Missing Final New Line in todo.txt

[nikbucher]

The current implementation does not append a final newline character when saving the todo.txt file. This behavior causes issues with the standard todo.txt CLI, which expects a final newline in the todo.txt file. As a result, a new task added by the CLI are appended to the last task instead of being placed on a new line.

Steps to Reproduce:

1. Save a todo.txt file using the current implementation.
2. Add a new task using the standard todo.txt CLI.
3. Notice that the new task is appended to the last task instead of being placed on a new line.

Expected Behavior:
A final newline character is added when the todo.txt file is saved, ensuring compatibility with the standard todo.txt CLI.

Suggested Fix:
Modify the writeToFile method to ensure that a final newline character is added when writing the todo.txt file here:

sleek/src/main/modules/File/Write.tsx

Lines 9 to 12 in c3fceea

	function writeToFile(string: string, filePath: string, bookmark: string | null) {
	const stopAccessingSecurityScopedResource = (process.mas && bookmark) ? app.startAccessingSecurityScopedResource(bookmark) : null;
	fs.writeFileSync(filePath, string, 'utf-8');

That would be great. Thanks a lot in advance.

Best regards - Nik

[ransome1]

@nikbucher this should technically not be a big issue. I can add this in the next (pre-)release. However, why do you consider it a bug? It's not a todo.txt rule, if I am not mistaken. The todo.txt CLI is one of many todo.txt apps and I don't actually see a good reason why it would expect an empty line at the end of the file. Or am I not seeing something here?

[nikbucher]

Hi @ransome1, thanks for your response!

You're right that it's not an explicitly stated rule. However, the sample file on todotxt.org includes a final newline, and the official todo.txt CLI expects it, suggesting it might be an unofficial convention.

Here are also a few technical reasons why adding a final newline to text files can be a good idea:

• POSIX Compliance: Unix-based systems (Linux/macOS) follow the POSIX standard, which considers a text file as a sequence of lines, each ending with a newline. Some tools behave unexpectedly if the last line is missing one.
• CLI Tools Behavior: Utilities like sed, awk, and grep assume each line is newline-terminated. Without it, certain operations might not work as intended.
• Text Editors: Editors like Vim often add a final newline automatically to maintain consistency with Unix conventions.
• Consistency with todo.txt CLI: Since the CLI expects a newline at the end, not having one causes issues like I mentioned in the initial ticket description.

Adding a final newline would improve compatibility and prevent unexpected behavior when switching between sleek and the CLI.

Hope this helps. Thanks a lot for the awesome sleek tool!

Best regards - Nik

[ransome1]

@nikbucher I added this behavior to the latest RC: https://github.com/ransome1/sleek/releases/tag/v2.0.19-rc.4

I hope it does not create any unexpected side effects. Let me know if it works as expected.

[ransome1]

Released as part of 2.0.19: https://github.com/ransome1/sleek/releases/tag/v2.0.19

[nikbucher]

Thanks alot - it works great!