Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Displayrotateupright.h" missing variable declaration #401

Closed
Extraweich opened this issue Dec 1, 2023 · 3 comments
Closed

"Displayrotateupright.h" missing variable declaration #401

Extraweich opened this issue Dec 1, 2023 · 3 comments

Comments

@Extraweich
Copy link

The variables "machineLogo" and "brewTime_last_Millis" are not set in "Displayrotateupright.h", preventing the user to use the vertical display design, if they set "DISPLAYTEMPLAE" to 20 in the "userConfig.h". Also the Docs refer to the "git Handbook" if the user is interested in such, but I cannot find this. It seems like this display template is not expected to be used anymore, but it is still part of the newest firmware.

@fiendie
Copy link
Member

fiendie commented Dec 1, 2023

To be fair, I suspect it's not that widely used but you're right: if it's there it should work. We'll look into it 😉

@LoQue90
Copy link
Member

LoQue90 commented Dec 6, 2023

hey @Extraweich do you want to see if this works for you?
#408
or did you just tried it out of curiosity

@LoQue90
Copy link
Member

LoQue90 commented Dec 8, 2023

should work again on V3.3.0
will be added to master V4.0 also

@LoQue90 LoQue90 closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants