Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Clarification [setting proxy information] #169

Closed
ghost opened this issue Nov 1, 2023 · 7 comments · May be fixed by #242
Closed

Request for Clarification [setting proxy information] #169

ghost opened this issue Nov 1, 2023 · 7 comments · May be fixed by #242
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Nov 1, 2023

According to the advanced configuration documentation: https://docs.rke2.io/advanced proxy configurations should be set in /etc/default/rke2-[server,agent].

Is that supported using either settings in group_vars/... or hosts.ini?

@jcox10
Copy link
Contributor

jcox10 commented Nov 3, 2023

I don't see anything in the roles that sets the the systemd proxy vars. However, you can set containerd to use a mirror to get to docker.io (see here). That file can contain your internal mirror (artifactory, nexus, etc. if you have one).

mirrors:
  docker.io:
    endpoint:
      - "https://your-docker-registry.something.com"

@ghost
Copy link
Author

ghost commented Nov 6, 2023

@jcox10 Thanks for that pointer.
I wonder if a PR with the added functionality of adding a proxy would be accepted and fall within the scope of this project?

@jcox10
Copy link
Contributor

jcox10 commented Nov 10, 2023

I would think anything listed in the documentation is acceptable to add to the ansible. For example, disabling firewalld is in the documentation and there is support for it in the ansible roles.

ghost pushed a commit to benhosmer/rke2-ansible that referenced this issue Nov 17, 2023
@ghost ghost mentioned this issue Nov 17, 2023
3 tasks
@Falltrades
Copy link

I tested #174 on my clusters and overall it is working as expected.
Unfortunately the guy who opened the PR deleted his account. Are there any maintainers who can help proceeding this PR ? @aleiner ?

@aleiner
Copy link
Contributor

aleiner commented Jun 1, 2024

@Falltrades , you should see something on Monday

@aleiner
Copy link
Contributor

aleiner commented Jun 3, 2024

Due to changes made, a new PR was submitted to address this request. #242

@aleiner aleiner added this to the v2.0.0 milestone Jan 14, 2025
aleiner pushed a commit that referenced this issue Jan 14, 2025
@aleiner aleiner mentioned this issue Jan 14, 2025
4 tasks
@aleiner aleiner self-assigned this Jan 14, 2025
Daemonslayer2048 pushed a commit that referenced this issue Jan 15, 2025
Co-authored-by: Adam Leiner <[email protected]>
@Daemonslayer2048
Copy link
Contributor

Looks good, merged.

Daemonslayer2048 added a commit that referenced this issue Jan 15, 2025
* initial commit

* validating

* fixing linting

* initial pass at tarball

* cleanup

* adding logic to determine join token and which node is up

* fixing some linting

* fixing some linting

* allowing rpm downgrade and forcing handlers on failure

* rpm install logic change

* large number of changes 01

* large number of changes 02

* readding throttles

* Add first molecule scenario

* Move VPC subnet to env var

* Convert default scenario to a template and ubuntu-2404

* Remove unused scenario files

* updating full rpm logic

* fixed rpm logic

* linting round 1

* Add supported platforms

* fixing VIP join logic

* Easy win yamllints

* yes/no are not bools

* Create galaxy.yml

* Update variable in example hosts.yml

* Install_rke2_version was renamed to rke2_install_version

* set become: false on local file lookup

* Docs update (#266)

* Add network attached instructions

* Update tarball docs

* Github does not support titled admons

* Clear some lint issues

* Clear some galaxy errors

* Clear some new lint issues

* Fix ansible semver string

* Use a supported ansible version

* Update file and folder names

* Update README instruction for inventory use

* Add vale linting, normalized file extensions, and doc tweaks

* Revert become change, remove superfluous docs in main readme

* adjusting config verbiage

---------

Co-authored-by: Adam Leiner <[email protected]>

* Ci review (#269)

* Add network attached instructions

* Update tarball docs

* Github does not support titled admons

* Clear some lint issues

* Clear some galaxy errors

* Clear some new lint issues

* Fix ansible semver string

* Use a supported ansible version

* Update file and folder names

* Import linting, split linting tasks

* Update README instruction o inventory use

* Add vale linting, normalized file extensions, and doc tweaks

* Tweak workflow lints

* Merge workflows back into one file

* Test sudo access

* Rename Rocky tests, install Terraform

* Fix rocky task dep

* Install Terraform attempt #2

* Test reusable workflows

* Add OS option

* Add OS option 2

* Inherit secrets

* Install yq

* Install yq #2

* Install yq #3

* Install yq #4

* Use YQ for inventory generation

* Fix missing close bracket

* Print hosts file for debugging

* You should cat hosts file for debugging not exec it

* Runn test

* Fix inventory file location

* Fix inventory and add ssh_user

* Fix second inventory

* Add rocky 9

* Update CI to reference JOBID

* Attempt move to AWS commercial

* Attempt move to AWS commercial 2

* Attempt move to AWS commercial 3

* Fix destroy command and defaults

* Fix AWS Region

* Tweak TF and simplify for debuggin

* Fix new var

* Remove new var

* Remove new var 2

* Fix bad EOF

* Fix delete job

* Reduce EC2 counts

* Add Rocky 9 back

* Name sec groups

* Add Ubuntu

* Fix using wrong OS

* Add SLES

* Fix issue where too in SLES does not have .bashrc

* Fix bad permission

* Update README, Remove SLES, Test Lint requirements

* Remove broken lint check

* Updat edocs

* increase yaml lint line-length

* removing sles tests until they are reimplemented

---------

Co-authored-by: Adam Leiner <[email protected]>
Co-authored-by: Adam Leiner <[email protected]>

* Fix vars

* Fix CI reading .ansible directory

* #169 (#274)

Co-authored-by: Adam Leiner <[email protected]>

* Add a non-vague warning banner for v2 release

* Update RGS branding

---------

Co-authored-by: Adam Leiner <[email protected]>
Co-authored-by: Mike DAmato <[email protected]>
Co-authored-by: Daemonslayer2048 <[email protected]>
Co-authored-by: Jacob Hanafin <[email protected]>
Co-authored-by: Jacob Hanafin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants