-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vsphere user-data.iso cleanup note #1601
Open
jakefhyde
wants to merge
1
commit into
rancher:main
Choose a base branch
from
jakefhyde:1535-vsphere-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
December 17, 2024 19:39
Oats87
approved these changes
Jan 3, 2025
Oats87
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakefhyde Made some changes based on the SUSE Style guide. Lmk if these changes are okay. Thanks!
@@ -52,6 +52,12 @@ If you have a cluster with DRS enabled, setting up [VM-VM Affinity Rules](https: | |||
|
|||
## Creating a VMware vSphere Cluster | |||
|
|||
:::note | |||
|
|||
vSphere node driver or custom clusters created prior to v2.9.1 may have resulted in user-data.iso files being orphaned on node deletion. While [this issue](https://github.com/rancher/rancher/issues/25073) will no longer occur, no automatic cleanup exists for these previously orphaned files. vSphere administrators can manually remove orphaned files, however care should be taken not to remove files in use by existing machines, as this may cause outages for downstream virtual machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
vSphere node driver or custom clusters created prior to v2.9.1 may have resulted in user-data.iso files being orphaned on node deletion. While [this issue](https://github.com/rancher/rancher/issues/25073) will no longer occur, no automatic cleanup exists for these previously orphaned files. vSphere administrators can manually remove orphaned files, however care should be taken not to remove files in use by existing machines, as this may cause outages for downstream virtual machines. | |
User-data.iso files may have become orphaned upon node deletion due to a vSphere node driver or custom clusters created before v2.9.1. While [this issue](https://github.com/rancher/rancher/issues/25073) is resolved, no automatic cleanup exists for these previously orphaned files. vSphere administrators can manually remove orphaned files, but be careful not to remove files being used by existing machines, as this may cause outages for downstream virtual machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Add warning on cleanu of
user-data.iso
s as per SURE-6985.Comments