Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width of select container drop down in log viewer bobbles on expand/collapse #12642

Open
richard-cox opened this issue Nov 21, 2024 · 3 comments · May be fixed by #12745
Open

Width of select container drop down in log viewer bobbles on expand/collapse #12642

richard-cox opened this issue Nov 21, 2024 · 3 comments · May be fixed by #12745
Labels
good-first-issue kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.12.0

Comments

@richard-cox
Copy link
Member

richard-cox commented Nov 21, 2024 •
edited
Loading

Setup

  • Rancher version: 2.10

Describe the bug

  • Width of select component expands to show Container: <container name>
  • When select component opens the Container part is removed and the width then shrinks

To Reproduce

  • Deploy a pod that has two containers
  • View logs
  • Expand/collapse container selector

Result

  • Width bobbles, made more ugly by three buttons on right moving around

Expected Result

  • Width of select remains the same

Screenshots
image

image

Additional context
@richard-cox richard-cox added this to the v2.12.0 milestone Nov 21, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 21, 2024
@richard-cox richard-cox mentioned this issue Nov 21, 2024
Open
@L-Abraham
Copy link

Hi @richard-cox,

This issue looks interesting, and I'd love to contribute to fixing it! This would be my first time contributing to an open-source project, and I’m excited to get involved with this repository.

Would it be okay if I worked on this issue?

Thank you, and I look forward to your response!

@richard-cox
Copy link
Member Author

Hi @L-Abraham, sorry for the slow response i was away last week.

Please do have a look at this issue, but it's currently targeted at 2.12 (we are actively working on 2.11 atm) and might be some time before we can review / test a PR.

L-Abraham pushed a commit to L-Abraham/dashboard that referenced this issue Dec 2, 2024
Fix: Prevent dropdown width from shrinking in container picker (ranch…
663735a 
…er#12642)
@L-Abraham L-Abraham linked a pull request Dec 2, 2024 that will close this issue
Open
7 tasks
@L-Abraham
Copy link

Hi @richard-cox, no worries at all! Thanks for the update. I’ve created a PR for this issue and understand it might take some time for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

Fix: Prevent dropdown width from shrinking in container picker (#12642) L-Abraham/dashboard
2 participants
@richard-cox @L-Abraham