Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode server-side pagination filter terms #11627

Open
richard-cox opened this issue Aug 12, 2024 · 1 comment · Fixed by #13209
Open

Encode server-side pagination filter terms #11627

richard-cox opened this issue Aug 12, 2024 · 1 comment · Fixed by #13209
Assignees
@richard-cox
Labels
area/performance area/server-side-pagination kind/bug QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Milestone
v2.11.0

Comments

@richard-cox
Copy link
Member

  • node list search by kube version will fail given it contains a +
  • the filter term should be encoded
    • /v1/nodes?filter=status.nodeInfo.kubeletVersion=1.30.2%2Bk
@richard-cox richard-cox added this to the v2.10.0 milestone Aug 12, 2024
@richard-cox richard-cox self-assigned this Aug 12, 2024
@github-actions github-actions bot added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed status/backport-candidate labels Aug 12, 2024
@richard-cox richard-cox modified the milestones: v2.10.0, v2.11.0 Sep 25, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@richard-cox richard-cox added the size/1 Size Estimate 1 label Jan 6, 2025
@richard-cox richard-cox mentioned this issue Jan 24, 2025
Merged
7 tasks
@yonasberhe23 yonasberhe23 added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Feb 6, 2025
@yonasberhe23
Copy link
Contributor

Requires manual validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-cox richard-cox

Labels
area/performance area/server-side-pagination kind/bug QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Encode the filter param that SSP uses richard-cox/dashboard
3 participants
@nwmac @richard-cox @yonasberhe23