You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue potentially affects and has chances of regressions: #599
This issue affects our ability to update and support for k8s 1.32. I found this issue in the process of making a draft PR to do this on main. In theory we can start that work because wrangler has an RC with 1.32 support. So I wanted us to be ahead of that task this time around.
In testing I found that our CI tests immediately start to fail when updating to the 0.32.0 apis that match k8s 1.32. Here is an example of the errors I'm seeing:
=== RUN TestIsDefaultEncryptionTransformer_PartialWildcard
util_test.go:78:
Error Trace: .../SUSE/backup-restore-operator/pkg/util/util_test.go:78
Error: Should be true
Test: TestIsDefaultEncryptionTransformer_PartialWildcard
--- FAIL: TestIsDefaultEncryptionTransformer_PartialWildcard (3.86s)
This test (and all other new failing tests) rely on our ability to check the transformer via:
This is due to a change in upstream k8s apiserver library which seems to no longer allow us to verify the transformer before it runs.
Granted because we are not the etcd/apiserver that is the target for this code we cannot be surprised. However we still need to find both a short term and long term solution for how we with to adapt to this type of issue. I think that for our current concern we should find a solution that works - but should open a tech-debt issue to consider the long-term solution if we want to maintain an internal version of this code instead of relying on potentially changing apiserver code.
The text was updated successfully, but these errors were encountered:
This allows PR1 to be backported and PR2 to be one that only lands at main. Overall this strategy should keep our active branches more similar in structure for maintainability. This way all active branches take some of the necessary changes for 1.32 but not all of them.
This issue potentially affects and has chances of regressions: #599
This issue affects our ability to update and support for k8s 1.32. I found this issue in the process of making a draft PR to do this on main. In theory we can start that work because wrangler has an RC with 1.32 support. So I wanted us to be ahead of that task this time around.
In testing I found that our CI tests immediately start to fail when updating to the
0.32.0
apis that match k8s1.32
. Here is an example of the errors I'm seeing:This test (and all other new failing tests) rely on our ability to check the transformer via:
backup-restore-operator/pkg/util/util.go
Lines 112 to 114 in 155b1a9
This is due to a change in upstream k8s apiserver library which seems to no longer allow us to verify the transformer before it runs.
Granted because we are not the etcd/apiserver that is the target for this code we cannot be surprised. However we still need to find both a short term and long term solution for how we with to adapt to this type of issue. I think that for our current concern we should find a solution that works - but should open a tech-debt issue to consider the long-term solution if we want to maintain an internal version of this code instead of relying on potentially changing apiserver code.
The text was updated successfully, but these errors were encountered: