Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ids are not properly set for subsymbols within a symbol group. #112

Open
viampietro opened this issue Apr 23, 2018 · 0 comments
Open

Ids are not properly set for subsymbols within a symbol group. #112

viampietro opened this issue Apr 23, 2018 · 0 comments
Assignees
Labels
activity Describe a coding task as one of the steps to achieve a whole user story

Comments

@viampietro
Copy link
Collaborator

There are few problems concerning the distribution of ids to subsymbols within a symbol group.

  • Ids are not well calculated when copying a symbol group.
  • Ids are not well calculated when creating a new symbol group from the palette.
  • Also, when creating a new symbol by cmd+click in a group, the id is not set at all (stays {type}/{palette})

I think the main problem is that there is no direct referencing between sub-components in a group and their sub-symbols. Sub-components don't have a pointer to their related sub-symbol entries in the group bundle.

I agree that all graphic components should have an attached symbol created in the model's score, and that symbol a group should own a list of pointers to their sub-symbols and not possess the entire bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activity Describe a coding task as one of the steps to achieve a whole user story
Projects
None yet
Development

No branches or pull requests

2 participants