Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store music database IDs in txt file #70

Closed
achimmihca opened this issue Jun 19, 2023 · 6 comments
Closed

Store music database IDs in txt file #70

achimmihca opened this issue Jun 19, 2023 · 6 comments

Comments

@achimmihca
Copy link

I found that you are using MusicBrainz database to get song information such as year, genre, artist, etc.

I think it makes sense to add the MBID to the txt file for future reference.
For example, other tools or games may use it to provide a link with further info to MusicBrainz.com or to fetch the album art if not present yet.

Suggestions for the UltraStar txt header fields: MBID_RECORD, MBID_ARTIST, MBID_RELEASE_GROUP, etc.

@bohning
Copy link
Contributor

bohning commented Jun 22, 2023

But isn’t artist = artists['artist-list'][0]['name'] simply taking the first artist of the search result, no matter if it is correct or not? It might be highly likely the very first entry, but in case it’s not a perfect match, it might also be some other entry of the search results, right? So it is dangerous to add MBID to a song based on best-guessing, isn’t it? (same for release group).

@rakuri255
Copy link
Owner

rakuri255 commented Jun 22, 2023

@bohning yeah thats true. I think it would be enough if we implement a better checker.
I also planing to trigger the search manually. See #75
That would help with odd youtube names.

@achimmihca
Copy link
Author

Good point.

If the user specifies a MBID manually, then it might make sense to save this for future reference.

In contrast, an automatically chosen MBID might cause issues.

@rakuri255
Copy link
Owner

@achimmihca Good point by just providing the MBID.

@rakuri255
Copy link
Owner

Will be added, when specification is done in UltraStar-Deluxe/format

@achimmihca achimmihca changed the title Store MusicBrainz IDs in txt file Store music database IDs in txt file Sep 27, 2023
@rakuri255
Copy link
Owner

The result from UltraStar-Deluxe/format#19 is, that it will be not added to the format.
So i close this as "wont do"

@rakuri255 rakuri255 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants