Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month selector not working as expected #250

Closed
jamesvsshark opened this issue Aug 31, 2016 · 5 comments
Closed

Month selector not working as expected #250

jamesvsshark opened this issue Aug 31, 2016 · 5 comments

Comments

@jamesvsshark
Copy link

If by default it is the last day of the month or I select the last day of the month and then choose the next month in the drop down -- the calendar will skip the correct next month and go to the following.

http://rajeshwarpatlolla.github.io/DatePickerForIonicFramework/demo/#/tab/home

  1. Open date picker and select October 31
  2. Change dropdown to November
  3. Expected - November becomes visible; Actual - December becomes visible
jamesvsshark added a commit to jamesvsshark/ionic-datepicker that referenced this issue Aug 31, 2016
…ted -- If by default it is the last day of the month or I select the last day of the month and then choose the next month in the drop down -- the calendar will skip the correct next month and go to the following.
@jamesvsshark
Copy link
Author

Possible fix in PR #251

@rajeshwarpatlolla
Copy link
Owner

It's not reproducing. I tested it in the demo link itself.

@dickverweij
Copy link

This is caused by the following code that appears everywhere in the code.

$scope.currentDate.setMonth(XXX)

For example:
if the currentDate = 31-Jan-2017 setting the month on februari
will result in 31-Feb-2017. That date does not exist and will result in 03-Mar-2017

@dickverweij
Copy link

funny this error will only reproduce on 31 or 30th of the month

@postb99
Copy link

postb99 commented Mar 29, 2017

Duplicate of #297, see comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants