Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create javascript bindings crate and implement order queries #978

Merged
merged 15 commits into from
Nov 8, 2024
Merged

Create javascript bindings crate and implement order queries #978

merged 15 commits into from
Nov 8, 2024

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Nov 6, 2024

Motivation

See issue: #966

Solution

  • Create another crate called js_api under crates.
  • Implement two order queries
    • Order details
    • Orders list (multichain)

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor self-assigned this Nov 6, 2024
rouzwelt
rouzwelt requested changes Nov 6, 2024
View reviewed changes
@findolor findolor changed the base branch from 2024-11-04-vault-list-multi-subgraph to main November 7, 2024 07:49
rouzwelt
rouzwelt requested changes Nov 7, 2024
View reviewed changes
@hardyjosh hardyjosh merged commit 4bd2143 into main Nov 8, 2024
20 checks passed
@findolor findolor mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

@rouzwelt rouzwelt rouzwelt approved these changes

Assignees

@findolor findolor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findolor @hardyjosh @rouzwelt