Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and gui yaml parsing #1230

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix and gui yaml parsing #1230

merged 3 commits into from
Feb 4, 2025

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Feb 4, 2025

Motivation

Solution

  • Improve network messages in order parsing
  • Use context for parsing a single deployment and order

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor added bug Something isn't working rust Related to rust crates labels Feb 4, 2025
@findolor findolor requested a review from hardyjosh February 4, 2025 12:54
@findolor findolor self-assigned this Feb 4, 2025
@findolor findolor linked an issue Feb 4, 2025 that may be closed by this pull request
"Network does not match" is a very unhelpful error #1222
Closed
@hardyjosh hardyjosh enabled auto-merge February 4, 2025 14:23
@hardyjosh hardyjosh merged commit 769a491 into main Feb 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@findolor findolor

Labels
bug Something isn't working rust Related to rust crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Network does not match" is a very unhelpful error
2 participants
@findolor @hardyjosh