Skip to content

Commit

Permalink
Merge branch 'main' into 01/13/25-remove-unused-BadgeExternalLink
Browse files Browse the repository at this point in the history
  • Loading branch information
hardingjam authored Jan 20, 2025
2 parents 92b2b7e + 5f63650 commit 6c9a515
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 2 deletions.
34 changes: 33 additions & 1 deletion crates/settings/src/deployer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ impl Deployer {
if let Some(deployer_yaml) =
deployers_hash.get(&StrictYaml::String(deployer_key.to_string()))
{
return require_string(deployer_yaml, Some("network"), None);
return require_string(deployer_yaml, Some("network"), None)
.or_else(|_| Ok(deployer_key.to_string()));
}
}
}
Expand Down Expand Up @@ -301,4 +302,35 @@ deployers:
YamlError::KeyShadowing("DuplicateDeployer".to_string())
);
}

#[test]
fn test_parse_deployer_from_yaml_network_key() {
let yaml = r#"
networks:
mainnet:
rpc: https://rpc.com
chain-id: 1
deployers:
mainnet:
address: 0x1234567890123456789012345678901234567890
network: mainnet
"#;

let documents = vec![get_document(yaml)];
let network_key = Deployer::parse_network_key(documents, "mainnet").unwrap();
assert_eq!(network_key, "mainnet");

let yaml = r#"
networks:
mainnet:
rpc: https://rpc.com
chain-id: 1
deployers:
mainnet:
address: 0x1234567890123456789012345678901234567890
"#;
let documents = vec![get_document(yaml)];
let network_key = Deployer::parse_network_key(documents, "mainnet").unwrap();
assert_eq!(network_key, "mainnet");
}
}
34 changes: 33 additions & 1 deletion crates/settings/src/orderbook.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ impl Orderbook {
if let Some(orderbook_yaml) =
orderbooks_hash.get(&StrictYaml::String(orderbook_key.to_string()))
{
return require_string(orderbook_yaml, Some("network"), None);
return require_string(orderbook_yaml, Some("network"), None)
.or_else(|_| Ok(orderbook_key.to_string()));
}
}
}
Expand Down Expand Up @@ -452,4 +453,35 @@ orderbooks:
YamlError::KeyShadowing("DuplicateOrderbook".to_string())
);
}

#[test]
fn test_parse_orderbook_from_yaml_network_key() {
let yaml = r#"
networks:
mainnet:
rpc: https://rpc.com
chain-id: 1
orderbooks:
mainnet:
address: 0x1234567890123456789012345678901234567890
network: mainnet
"#;

let documents = vec![get_document(yaml)];
let network_key = Orderbook::parse_network_key(documents, "mainnet").unwrap();
assert_eq!(network_key, "mainnet");

let yaml = r#"
networks:
mainnet:
rpc: https://rpc.com
chain-id: 1
orderbooks:
mainnet:
address: 0x1234567890123456789012345678901234567890
"#;
let documents = vec![get_document(yaml)];
let network_key = Orderbook::parse_network_key(documents, "mainnet").unwrap();
assert_eq!(network_key, "mainnet");
}
}

0 comments on commit 6c9a515

Please sign in to comment.