Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unclearable orders #312

Open
rouzwelt opened this issue Feb 19, 2025 · 0 comments
Open

skip unclearable orders #312

rouzwelt opened this issue Feb 19, 2025 · 0 comments

Comments

@rouzwelt
Copy link
Collaborator

rouzwelt commented Feb 19, 2025

Problem

Currently active orders that are "dead" (ie have zero maxoutput or have dust in them or intentionally or not constantly fail the quote call), occupy bot resources and reduce the overal performance and effeciency of the bot since it result in less clearable orders being processed in a given window of time.

Proposed Solution

To address this issue, bot needs to skip those orders, by identifying those orders when they happen to have dust or zero maxoutput for them over some timeframe or fail quote constantly, eg when an order has dust for let's say 30 mins straight, it will be moved to skippable list, the skippable list will then be watched for changes that canbe wtached over by subgraph changes for those orders ) and when there is deposit for the given order it will be moved out of the list and/order re-evaluated after some time (let's say a few hours). and this process will repeat again. This way the skip list will be updated constantly and makes sure no order will stay there forever

This also incentives owners to remove their orders once they are out of vault balance or have very small dust in them or as failing quote since it is easy to activate them again in future with very minimal gas cost, and orders that go into skip list might not come out of the list right away to be processed by bot.

so let's break down the solution:

  • identify active skippable orders (ie zero maxoutput/dust and constantly failing quote) by watching them over some arbitrary timeframe
  • identified orders go into skip list and will not be processed on rounds until they come out of the list for some reason
  • for an order to get out of the list:
    • orders with dust/zero maxoutput will be watched for new deposits, once there is one, they will come out of the list
    • orders that constantly fail quote will be re-evaluated after their timer hits, the timer can be a contant value for all owners or an owner based cli option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant