Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Allow node_modules to be included in deployments with railway up #496

Open
mikebywaters opened this issue May 16, 2024 · 2 comments

Comments

@mikebywaters
Copy link

Problem

railway up ignores node_modules by default:
https://github.com/railwayapp/cli/blob/2d2a8c14385368662059e2781c4d2412aef419a9/src/commands/up.rs#L184C34-L184C46
but there are use cases where deploying the contents of node_modules is desirable, eg. when the dependency install is being done as part of another CI pipeline (eg. GitHub Actions, Buildkite) and isn't part of the Docker container.

Potential solutions

  1. Remove the default behaviour
  2. Provide a flag that enables the behaviour to be bypassed
Copy link

Hello, @mikebywaters! Thanks for your submission.

Our team will respond soon. If you need more immediate help, try our Forum or our Discord. Thanks!

@mikebywaters mikebywaters changed the title Allow node_modules to be included in deployments with railway up Suggestion: Allow node_modules to be included in deployments with railway up May 16, 2024
@maddsua
Copy link
Contributor

maddsua commented Aug 16, 2024

Hey @mikebywaters!
Just yesterday we got the CLI image published to ghcr. Now you can build everything inside of CI environment of your choice and then push the result to railway with a minimal dockerfile or nix config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants