Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rchardet19 upgrade #54

Closed
Laykou opened this issue Nov 14, 2021 · 2 comments
Closed

rchardet19 upgrade #54

Laykou opened this issue Nov 14, 2021 · 2 comments

Comments

@Laykou
Copy link

Laykou commented Nov 14, 2021

Is there any specific dependency on rchardet19 gem or could it be upgraded to latest rchardet?

It also contains support for Ruby 1.9.

https://github.com/jmhodges/rchardet

If we use e.g. git gem which has this as dependency, there is conflict in some constants with rchardet19 version.

gems/rchardet19-1.3.7/lib/rchardet19.rb:59: warning: already initialized constant CharDet::VERSION
gems/rchardet-1.8.0/lib/rchardet/version.rb:2: warning: previous definition of VERSION was here

I know it's only warning, but I'd like to resolve it

@janz93
Copy link
Contributor

janz93 commented Jan 7, 2025

same problem as #55 and therefore can be closed

@janz93 janz93 closed this as completed Jan 7, 2025
@Laykou
Copy link
Author

Laykou commented Jan 7, 2025

Haha thank you. I see this has been couple of years. We already forked this and are using our local branch. But I will be glad to switch back to officially supported version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants