You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a test that explicitly calls an exit 0 under certain conditions which should then trigger SystemExit. I am not sure what change caused this but when upgrading to Thor 1.3.0 from 1.2.2, SystemExit is no longer called in this case. I know that there were changes in 1.0.0 around exit_on_failure? (which I am not explicitly calling at this point) but looking through the code changes for the 1.3.0 update, I cannot see what possibly could be the issue. Would someone be able to point me in the right direction? Not sure if I need to change something or if the behaviour I had is simply no longer possible. Thanks!!
The text was updated successfully, but these errors were encountered:
Hard to know how to point you to the right direction if we don't know how to reproduce the problem. Could you please provide information on how we can reproduce the problem?
We have a test that explicitly calls an exit 0 under certain conditions which should then trigger
SystemExit
. I am not sure what change caused this but when upgrading to Thor 1.3.0 from 1.2.2,SystemExit
is no longer called in this case. I know that there were changes in 1.0.0 aroundexit_on_failure?
(which I am not explicitly calling at this point) but looking through the code changes for the 1.3.0 update, I cannot see what possibly could be the issue. Would someone be able to point me in the right direction? Not sure if I need to change something or if the behaviour I had is simply no longer possible. Thanks!!The text was updated successfully, but these errors were encountered: