Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you consider adding support for custom fetch options? #85

Open
brendon opened this issue Mar 5, 2025 · 4 comments · May be fixed by #86
Open

Would you consider adding support for custom fetch options? #85

brendon opened this issue Mar 5, 2025 · 4 comments · May be fixed by #86

Comments

@brendon
Copy link
Contributor

brendon commented Mar 5, 2025

I was wanting to make a fetch request using keepalive: true but the fetch options are hard-coded. Would you be open to making them configurable?
@marcelolx
Copy link
Collaborator

Hey @brendon, yes — feel free to send a PR

@brendon
Copy link
Contributor Author

brendon commented Mar 5, 2025

Thanks @marcelolx, I'll take a look at that.

@brendon brendon linked a pull request Mar 8, 2025 that will close this issue
Open
@brendon
Copy link
Contributor Author

brendon commented Mar 9, 2025

Hi @marcelolx, I ended up just adding keepalive to the list of supported options. I'll take another look at just allowing all options through now that I've had some sleep :)

@brendon
Copy link
Contributor Author

brendon commented Mar 9, 2025 •
edited
Loading

Actually, this will be quite a big change and might not be worth the upheaval. Better to just add options as they're added to the fetch api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ability to pass through the keepalive configuration option brendon/request.js
2 participants
@brendon @marcelolx