Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention the "after_commit" callback in the README #42

Open
donv opened this issue Mar 7, 2016 · 3 comments
Open

Mention the "after_commit" callback in the README #42

donv opened this issue Mar 7, 2016 · 3 comments

Comments

@donv
Copy link

donv commented Mar 7, 2016

So that new developers can know that it exists, and know when it is called.
@rafaelfranca
Copy link
Member

Feel free to submit a pull request.

@donv
Copy link
Author

donv commented Mar 7, 2016

Hi @rafaelfranca !

Thanks for the quick response. I'll submit a PR, but I have one question first: Should "after_commit" be called for an update that is stopped by the "dirty" module since there were no changes? I would expect not, but I think I see this in at least one of our apps.

Just to clarify for the README change.

@rafaelfranca
Copy link
Member

If no commits are made to the database it should not run. If it is happen seems like a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaelfranca @donv