Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable tests #10

Open
karlb opened this issue Jul 28, 2022 · 0 comments
Open

Reenable tests #10

karlb opened this issue Jul 28, 2022 · 0 comments

Comments

@karlb
Copy link
Contributor

karlb commented Jul 28, 2022

After merging the arbitrum changes, some tests were skipped to make the rest of the test suite run again. Unskip and fix these tests.

$ ag 'Broken by arbitrum changes'
raiden_common/tests/unit/utils/test_filters.py
14:@pytest.mark.skip(reason="Broken by arbitrum changes")

raiden_common/tests/unit/test_pfs_integration.py
248:@pytest.mark.skip(reason="Broken by arbitrum changes")
279:@pytest.mark.skip(reason="Broken by arbitrum changes")
515:@pytest.mark.skip(reason="Broken by arbitrum changes")
573:@pytest.mark.skip(reason="Broken by arbitrum changes")
631:@pytest.mark.skip(reason="Broken by arbitrum changes")

Do this after #9, so that we don't spend time on fixing tests for code we are about to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant