Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db_seed with consistent case records #3177

Open
7 tasks
andrew-jameson opened this issue Sep 9, 2024 · 0 comments
Open
7 tasks

Update db_seed with consistent case records #3177

andrew-jameson opened this issue Sep 9, 2024 · 0 comments
Labels
dev DX Developer Experience integrationtests P3 Needed – Routine Refined Ticket has been refined at the backlog refinement

Comments

@andrew-jameson
Copy link
Collaborator

Description:
From this comment, @elipe17 found that we should be rejecting the record on cat4 grounds but that we were not and would need to add an increment of num_errors within the validate() call of case_consistency_validator.py.

Acceptance Criteria:

  • db_seed can correctly generate a case that passes cat 4 validation
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:

  • Increment num_errors
  • update seed_db.py to implement internally consistent case records
  • ensure we still get occasional cat4 errors/failures [stretch?]
  • Run Testing Checklist and confirm all tests pass

Notes:

Supporting Documentation:

Open Questions:

  • Do we want to add the increment and reject all records of a case with any cat4 issues?
@robgendron robgendron added Refined Ticket has been refined at the backlog refinement P3 Needed – Routine labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev DX Developer Experience integrationtests P3 Needed – Routine Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

No branches or pull requests

2 participants