Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple improvements to code #29

Open
DavidWC opened this issue Dec 30, 2020 · 0 comments
Open

Simple improvements to code #29

DavidWC opened this issue Dec 30, 2020 · 0 comments

Comments

@DavidWC
Copy link

DavidWC commented Dec 30, 2020

I'd like to give a couple of suggestions to improvements to the code. In particular, the use of strings to identify the different variations of the transforms is error-prone, inefficient, and hard to use. These would be much better handled as enumeration types.

I would also recommend liberal use of "const" and "restrict" for your pointers to the data. These will improve the quality of the code by reducing the risk of errors and improving the clarity to the reader, and can give significant speed benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant