Reuse empty array constants.

Refactor empty array constants.

Author: garydgregory

log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java

@@ -62,8 +62,7 @@ private void parse(final String pattern, final boolean convert, final StringBuil
         final List<PatternConverter> converters = new ArrayList<>();
         final List<FormattingInfo> fields = new ArrayList<>();
         parser0.parse(pattern, converters, fields, false, false, convert);
-        final FormattingInfo[] infoArray = new FormattingInfo[fields.size()];
-        final FormattingInfo[] patternFields = fields.toArray(infoArray);
+        final FormattingInfo[] patternFields = fields.toArray(FormattingInfo.EMPTY_ARRAY);
         final ArrayPatternConverter[] converterArray = new ArrayPatternConverter[converters.size()];
         final ArrayPatternConverter[] patternConverters = converters.toArray(converterArray);
         formatFileName(patternConverters, patternFields, buf, date, i);

log4j-slf4j-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java

@@ -35,7 +35,7 @@ public void testCleanup() throws Exception {
         Log4jLoggerFactory factory = (Log4jLoggerFactory) StaticLoggerBinder.getSingleton().getLoggerFactory();
         factory.getLogger("test");
         Set<LoggerContext> set = factory.getLoggerContexts();
-        LoggerContext ctx1 = set.toArray(new LoggerContext[0])[0];
+        LoggerContext ctx1 = set.toArray(LoggerContext.EMPTY_ARRAY)[0];
         assertTrue("LoggerContext is not enabled for shutdown", ctx1 instanceof LifeCycle);
         ((LifeCycle) ctx1).stop();
         set = factory.getLoggerContexts();

log4j-slf4j18-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java

@@ -35,7 +35,7 @@ public void testCleanup() throws Exception {
         Log4jLoggerFactory factory = (Log4jLoggerFactory) LoggerFactory.getILoggerFactory();
         factory.getLogger("test");
         Set<LoggerContext> set = factory.getLoggerContexts();
-        LoggerContext ctx1 = set.toArray(new LoggerContext[0])[0];
+        LoggerContext ctx1 = set.toArray(LoggerContext.EMPTY_ARRAY)[0];
         assertTrue("LoggerContext is not enabled for shutdown", ctx1 instanceof LifeCycle);
         ((LifeCycle) ctx1).stop();
         set = factory.getLoggerContexts();