Segmented Control has broken classic variant

[thien-do]

Since #621, the "classic" variant no longer has its shadow, even when it is not disabled. This can be seen in the playground of that PR:

I understand from the design (mentioned in the PR) that the disable style is the same for both "classic" and "surface" variants. However, I believe it's not intentional for the "classic" style to lose its shadow when not being disabled due to this change.

In fact, the absence of shadow in disabled state is more likely to be an unintentional issue. The code change (permalink) means the selectors will never match.

We can see this from the final CSS as well:

/* https://unpkg.com/browse/@radix-ui/[email protected]/styles.css */
.rt-SegmentedControlRoot:where(.rt-variant-surface) :where(.rt-SegmentedControlItem:not([disabled])) :where(.rt-SegmentedControlIndicator)::before {
  box-shadow: 0 0 0 1px var(--gray-a4);
}

/* https://unpkg.com/browse/@radix-ui/[email protected]/styles.css */
.rt-SegmentedControlRoot:where(.rt-variant-surface) :where(.rt-SegmentedControlIndicator)::before {
  box-shadow: 0 0 0 1px var(--gray-a4);
}

Because the structure of Segmented Control is that:

Root
- Item
- Item
- Indicator

The selector in 3.1.6 will never match anything, while the one in 3.1.4 does.

[thien-do]

cc @kendallstrautman and @chaance as you folks were working on the mentioned PR 😄 (sorry in advance if I should not cc people here. This is my fisrt issue in Radix)

[kendallstrautman]

Thanks for the report @thien-do, that change should not have affected the shadows. We'll take a look!