New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`*: transition: none` still present after theme change #615

Open

ProbableTrain opened this issue Oct 24, 2024 · 0 comments

ProbableTrain commented Oct 24, 2024 •

edited

Loading

After changing themes via the theme panel, transition-disabling styles are still present:

*,*::before,*::after{-webkit-transition:none!important;-moz-transition:none!important;-o-transition:none!important;-ms-transition:none!important;transition:none!important}

Possibly because we're not calling cleanup() before the early return here, in theme-panel.handleAppearanceChange:

themes/packages/radix-ui-themes/src/components/theme-panel.tsx

Lines 70 to 78 in 5142179

    
           const handleAppearanceChange = React.useCallback( 
        
             (value: 'light' | 'dark') => { 
        
               const cleanup = disableAnimation(); 
        
               if (appearance !== 'inherit') { 
        
                 onAppearanceChange(value); 
        
                 return; 
        
               }

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment