Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author-only tests are executed as part of make test #392

Open
chrisnovakovic opened this issue Apr 1, 2022 · 0 comments · May be fixed by #393
Open

Author-only tests are executed as part of make test #392

chrisnovakovic opened this issue Apr 1, 2022 · 0 comments · May be fixed by #393
Assignees
Labels
tech-debt Technical debt

Comments

@chrisnovakovic
Copy link
Collaborator

The following author-only tests are run as part of the standard Net-SSLeay test suite:

  • t/local/01_pod.t
  • t/local/02_pod_coverage.t
  • t/local/kwalitee.t

These only need to be run as part of CI jobs and release testing, and are usually skipped on end-user machines anyway (owing to their stealth dependency on the non-core Test::Pod, Test::Pod::Coverage and Test::Kwalitee modules respectively).

We'd be better off moving these tests to an xt/-like directory structure and adding a snippet to Makefile.PL to generate an xtest target that executes them.

@chrisnovakovic chrisnovakovic added the tech-debt Technical debt label Apr 1, 2022
@chrisnovakovic chrisnovakovic self-assigned this Apr 2, 2022
chrisnovakovic added a commit to chrisnovakovic/p5-net-ssleay that referenced this issue Apr 2, 2022
The following author-only tests are run as part of the standard test
suite:

* t/local/01_pod.t
* t/local/02_pod_coverage.t
* t/local/kwalitee.t

These only need to be run as part of CI jobs and release testing, and
are usually skipped on end-user machines anyway (owing to their stealth
dependency on the non-core Test::Pod, Test::Pod::Coverage and
Test::Kwalitee modules respectively).

Move these tests to the xt/ directory, declare their Test:: dependencies
as development prerequisites, and add an xtest target to the generated
Makefile that runs these tests.

Closes radiator-software#392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant